Prepend DOI and ARXIV URL origin when adding new url in the form#832
Open
shinyichen wants to merge 2 commits intoadsabs:masterfrom
Open
Prepend DOI and ARXIV URL origin when adding new url in the form#832shinyichen wants to merge 2 commits intoadsabs:masterfrom
shinyichen wants to merge 2 commits intoadsabs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
========================================
+ Coverage 62.5% 62.5% +0.1%
========================================
Files 317 317
Lines 36576 36578 +2
Branches 1673 1674 +1
========================================
+ Hits 22827 22838 +11
+ Misses 13709 13700 -9
Partials 40 40
🚀 New features to boost your workflow:
|
thostetler
approved these changes
Apr 3, 2026
Member
thostetler
left a comment
thostetler
left a comment
There was a problem hiding this comment.
LGTM -- just a quick question
| value: t as string, | ||
| })); | ||
|
|
||
| const DOI_ORIGIN = 'https://doi.org'; |
Member
There was a problem hiding this comment.
Looks good, however I wonder if there is a case for putting these in our central config src/config.ts ?
shinyichen
force-pushed
the
SCIX-854-DOI-validation
branch
from
5c4ec02 to
f48ac98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid confusion of DOI and arxiv format in the URL by prepending the origin.